From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: kvmtrace: kvmtrace_format for supporting big_endian Date: Thu, 12 Jun 2008 15:51:48 +0300 Message-ID: <48511BE4.3050005@qumranet.com> References: <08DF4D958216244799FC84F3514D70F0017C554B@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: "Tan, Li" Return-path: Received: from il.qumranet.com ([212.179.150.194]:45327 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757726AbYFLMxz (ORCPT ); Thu, 12 Jun 2008 08:53:55 -0400 In-Reply-To: <08DF4D958216244799FC84F3514D70F0017C554B@pdsmsx415.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Tan, Li wrote: > Avi, > Do you have any comments? No, just overloaded. Thanks for the reminder. > > Subject: [PATCH] [PATCH] kvm: kvmtrace: kvmtrace_format for supporting > big_endian > Currently kvmtrace is not portable, and prevent from copying > a trace file from big-endian target to little-endian > workstation for analysis. > In the patch, kvmtrace_format reads and checks the magic > number from trace log. if needed, then change bytes order > of all fields in records followed. Applied, thanks. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.