From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 0 of 2] Remove --disable-cpu-emulation for qemu Date: Fri, 13 Jun 2008 12:44:24 -0500 Message-ID: <4852B1F8.1050802@codemonkey.ws> References: <1213371109.11269.1.camel@thinkpadL> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org To: jyoung5@us.ibm.com Return-path: Received: from yw-out-2324.google.com ([74.125.46.28]:34110 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbYFMRor (ORCPT ); Fri, 13 Jun 2008 13:44:47 -0400 Received: by yw-out-2324.google.com with SMTP id 9so2553442ywe.1 for ; Fri, 13 Jun 2008 10:44:46 -0700 (PDT) In-Reply-To: <1213371109.11269.1.camel@thinkpadL> Sender: kvm-owner@vger.kernel.org List-ID: Jerone Young wrote: > After getting some private emails on this patch. I felt that I needed to > say that these patches probably should not go in. > I agree with your sentiment, --disable-cpu-emulation is a terrible hack that's is only going to make things difficult to merge with upstream. The proper solution is to implement a -kvm target type much like -softmmu and -linux-user. So I think this patch series should go in. Regards, Anthony Liguori > There is some value in having a kvm only binary. So having the --disable > cpu-emulation flag still has value. > > > So best not to remove this honestly until everything completely merges > with upstream qemu. > > On Tue, 2008-06-10 at 13:50 -0500, Jerone Young wrote: > >> These patches remove all traces of --disable-cpu-emulation configuration flag. >> >> Signed-off-by: Jerone Young >> >> 6 files changed, 2 insertions(+), 227 deletions(-) >> qemu/Makefile.target | 6 -- >> qemu/configure | 13 ----- >> qemu/target-i386/fake-exec.c | 54 --------------------- >> qemu/target-ia64/fake-exec.c | 44 ----------------- >> qemu/target-ppc/fake-exec.c | 104 ------------------------------------------ >> qemu/vl.c | 8 --- >> -- >> To unsubscribe from this list: send the line "unsubscribe kvm" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >