From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Do not calculate linear rip in emulation failure report Date: Sat, 14 Jun 2008 05:14:36 +0300 Message-ID: <4853298C.7090109@qumranet.com> References: <1213105613-8571-1-git-send-email-gcosta@redhat.com> <52d4a3890806131033g56ec2bc0o43442d2c290401f2@mail.gmail.com> <5d6222a80806131037u245c66ev902fadaa6d5c4605@mail.gmail.com> <4852CE93.9020104@qumranet.com> <5d6222a80806131251q12fbbff0rc90a133722acf2d7@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Mohammed Gamal , Glauber Costa , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org To: Glauber Costa Return-path: Received: from il.qumranet.com ([212.179.150.194]:34978 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbYFNCOq (ORCPT ); Fri, 13 Jun 2008 22:14:46 -0400 In-Reply-To: <5d6222a80806131251q12fbbff0rc90a133722acf2d7@mail.gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: >> >> I've changed it to use printk_ratelimit(). >> > > I've tested this option here before sending out the patch, since it > would address all issues. > > But in error cases, it still seemed to generate too many messages. > > Isn't that a bug in printk_ratelimit(), then? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.