From: Avi Kivity <avi@qumranet.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Mohammed Gamal <m.gamal005@gmail.com>,
kvm@vger.kernel.org, riel@surriel.com
Subject: Re: [PATCH] x86_emulate: Emulate nop (0x90) instruction
Date: Sat, 14 Jun 2008 18:26:22 +0300 [thread overview]
Message-ID: <4853E31E.7020101@qumranet.com> (raw)
In-Reply-To: <4853DF0A.6030401@firstfloor.org>
Andi Kleen wrote:
>> Thanks for pointing this out. 0x90 is also the opcode for xchg r8,rAX
>> instruction.
>>
>
> But nop doesn't actually need to execute exchange.
>
The sequence 0x41 0x90 uses the 0x90 opcode but is not a nop.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2008-06-14 15:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-14 11:50 [PATCH] x86_emulate: Emulate nop (0x90) instruction Mohammed Gamal
2008-06-14 13:26 ` Andi Kleen
2008-06-14 13:35 ` Mohammed Gamal
2008-06-14 15:08 ` Andi Kleen
2008-06-14 15:26 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4853E31E.7020101@qumranet.com \
--to=avi@qumranet.com \
--cc=andi@firstfloor.org \
--cc=kvm@vger.kernel.org \
--cc=m.gamal005@gmail.com \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox