From: Avi Kivity <avi@qumranet.com>
To: Mark McLoughlin <markmc@redhat.com>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/1] kvm: qemu: Add VIRTIO_F_NOTIFY_ON_EMPTY
Date: Wed, 18 Jun 2008 06:31:48 -0700 [thread overview]
Message-ID: <48590E44.2030202@qumranet.com> (raw)
In-Reply-To: <1213362983-17025-1-git-send-email-markmc@redhat.com>
Mark McLoughlin wrote:
> Set the VIRTIO_F_NOTIFY_ON_EMPTY feature bit so the
> guest can rely on us notifying them when the queue
> is empty.
>
> Also, only notify when the available queue is empty
> *and* when we've finished with all the buffers we
> had detached. Right now, when the queue is empty,
> we notify the guest for every used buffer.
>
This is a bit inflexible. I would prefer a mechanism where the guest
tells us at what queue index it would like the notification, like Xen.
If it wants it on queue empty, it just sets the index appropriately.
Or is the usage in the drivers already upstream and I have no choice
about applying this?
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2008-06-18 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-13 13:16 [PATCH 1/1] kvm: qemu: Add VIRTIO_F_NOTIFY_ON_EMPTY Mark McLoughlin
2008-06-18 13:31 ` Avi Kivity [this message]
2008-06-18 17:21 ` Mark McLoughlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48590E44.2030202@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox