From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Initialize kvm qemu enviroment breakpoints for PowerPC Date: Wed, 18 Jun 2008 06:39:10 -0700 Message-ID: <48590FFE.3040707@qumranet.com> References: <600753fabc8b38e54129.1213021421@thinkpadL> <1213023282.3358.2.camel@localhost.localdomain> <1213024001.6792.17.camel@thinkpadL> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Hollis Blanchard , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org To: jyoung5@us.ibm.com Return-path: Received: from il.qumranet.com ([212.179.150.194]:33219 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754089AbYFRNjO (ORCPT ); Wed, 18 Jun 2008 09:39:14 -0400 In-Reply-To: <1213024001.6792.17.camel@thinkpadL> Sender: kvm-owner@vger.kernel.org List-ID: Jerone Young wrote: > On Mon, 2008-06-09 at 09:54 -0500, Hollis Blanchard wrote: > >> On Mon, 2008-06-09 at 09:23 -0500, Jerone Young wrote: >> >>> diff --git a/qemu/gdbstub.c b/qemu/gdbstub.c >>> --- a/qemu/gdbstub.c >>> +++ b/qemu/gdbstub.c >>> @@ -983,6 +983,7 @@ static int gdb_handle_packet(GDBState *s >>> kvm_load_registers(env); >>> #elif defined (TARGET_PPC) >>> env->nip = addr; >>> + kvm_load_registers(env); >>> #elif defined (TARGET_SPARC) >>> env->pc = addr; >>> env->npc = addr + 4; >>> @@ -1021,6 +1022,7 @@ static int gdb_handle_packet(GDBState *s >>> kvm_load_registers(env); >>> #elif defined (TARGET_PPC) >>> env->nip = addr; >>> + kvm_load_registers(env); >>> #elif defined (TARGET_SPARC) >>> env->pc = addr; >>> env->npc = addr + 4; >>> >> These should be protected by a kvm_enabled() test, just like you see for >> x86 four lines earlier.A >> > > Actually the line above is x86 and it is not using kvm_enabled() before > calling kvm_load_registers(). > > Yes, kvm_load_registers() has a built-in kvm_enabled() test. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.