From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] make qemu compile for kvm/ia64
Date: Wed, 18 Jun 2008 06:42:02 -0700
Message-ID: <485910AA.3070705@qumranet.com>
References: <51CFAB8CB6883745AE7B93B3E084EBE201D2C4F2@pdsmsx412.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, kvm-ia64@vger.kernel.org
To: "Xu, Anthony" <anthony.xu@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:33755 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754868AbYFRNmG (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 18 Jun 2008 09:42:06 -0400
In-Reply-To: <51CFAB8CB6883745AE7B93B3E084EBE201D2C4F2@pdsmsx412.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Xu, Anthony wrote:
> From 7b2c2612b21b895cd14e632fea845c03b6e1dedc Mon Sep 17 00:00:00 2001
> From: Anthony Xu  <anthony.xu@intel.com>
> Date: Thu, 29 May 2008 13:14:56 -0400
> Subject: [PATCH] Make qemu compile for kvm-ia64
>
> Since merging with Qemu upsteram, it can't be compiled
> for kvm-ia64
>
> @@ -620,7 +622,10 @@ int cpu_exec(CPUState *env1)
>                  env = cpu_single_env;
>  #define env cpu_single_env
>  #endif
> +
> +#if !defined(TARGET_IA64)
>                  next_tb = tcg_qemu_tb_exec(tc_ptr);
> +#endif
>   

Instead of sprinkling all those ifdefs, how about proving stubs 
instead?  It will reduce the merge overhead, and will be easier to fix 
if/when tcg can target ia64.


-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.