From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH 1/5] vring: Replace mmap() interface with ioctl()
Date: Wed, 18 Jun 2008 07:05:39 -0700
Message-ID: <48591633.8060608@qumranet.com>
References: <1213365481-23460-1-git-send-email-markmc@redhat.com>	 <1213365481-23460-2-git-send-email-markmc@redhat.com>	 <48527FB2.1060409@qumranet.com> <1213705146.31834.3.camel@muff>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Rusty Russell <rusty@rustcorp.com.au>, kvm@vger.kernel.org
To: Mark McLoughlin <markmc@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:37895 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752093AbYFROGF (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 18 Jun 2008 10:06:05 -0400
In-Reply-To: <1213705146.31834.3.camel@muff>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Mark McLoughlin wrote:
> On Fri, 2008-06-13 at 17:09 +0300, Avi Kivity wrote:
>   
>> Mark McLoughlin wrote:
>>     
>>> -	.ioctl		= vring_ioctl,
>>> +	.unlocked_ioctl	= vring_ioctl,
>>> +	.compat_ioctl	= vring_compat_ioctl,
>>>   
>>>       
>> I think you can set compat_ioctl = vring_ioctl (that's what kvm does).
>>     
>
> Don't pointer args need the compat_ptr() conversion on s390x?
>
>   

Ouch.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.