public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] libkvm: export init for coalesced MMIO support
@ 2008-06-18  5:22 Carlo Marcelo Arenas Belon
  2008-06-18  7:39 ` Laurent Vivier
  2008-06-18 14:27 ` Avi Kivity
  0 siblings, 2 replies; 3+ messages in thread
From: Carlo Marcelo Arenas Belon @ 2008-06-18  5:22 UTC (permalink / raw)
  To: kvm

complement 2680f3df932a3119880a692609943587ecc8f409 to export the
definition for kvm_init_coalesced_mmio as it is used by the per
arch libkvm as shown by the following warning :

  libkvm-x86.c: In function 'kvm_arch_create':
  libkvm-x86.c:182: warning: implicit declaration of function 'kvm_init_coalesced_mmio'

Signed-off-by: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
---
 libkvm/libkvm.h |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/libkvm/libkvm.h b/libkvm/libkvm.h
index a33e9db..4fd8587 100644
--- a/libkvm/libkvm.h
+++ b/libkvm/libkvm.h
@@ -576,6 +576,15 @@ int kvm_set_lapic(kvm_context_t kvm, int vcpu, struct kvm_lapic_state *s);
  */
 int kvm_pit_in_kernel(kvm_context_t kvm);
 
+/*!
+ * \brief Initialize coalesced MMIO
+ *
+ * Check for coalesced MMIO capability and store in context
+ *
+ * \param kvm Pointer to the current kvm_context
+ */
+int kvm_init_coalesced_mmio(kvm_context_t kvm);
+
 #ifdef KVM_CAP_PIT
 
 #if defined(__i386__) || defined(__x86_64__)
-- 
1.5.4.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] libkvm: export init for coalesced MMIO support
  2008-06-18  5:22 [PATCH] libkvm: export init for coalesced MMIO support Carlo Marcelo Arenas Belon
@ 2008-06-18  7:39 ` Laurent Vivier
  2008-06-18 14:27 ` Avi Kivity
  1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2008-06-18  7:39 UTC (permalink / raw)
  To: Carlo Marcelo Arenas Belon; +Cc: kvm

Le mercredi 18 juin 2008 à 00:22 -0500, Carlo Marcelo Arenas Belon a
écrit :
> complement 2680f3df932a3119880a692609943587ecc8f409 to export the
> definition for kvm_init_coalesced_mmio as it is used by the per
> arch libkvm as shown by the following warning :
> 
>   libkvm-x86.c: In function 'kvm_arch_create':
>   libkvm-x86.c:182: warning: implicit declaration of function 'kvm_init_coalesced_mmio'
> 
> Signed-off-by: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>

Looks good for me.

Laurent
> ---
>  libkvm/libkvm.h |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/libkvm/libkvm.h b/libkvm/libkvm.h
> index a33e9db..4fd8587 100644
> --- a/libkvm/libkvm.h
> +++ b/libkvm/libkvm.h
> @@ -576,6 +576,15 @@ int kvm_set_lapic(kvm_context_t kvm, int vcpu, struct kvm_lapic_state *s);
>   */
>  int kvm_pit_in_kernel(kvm_context_t kvm);
>  
> +/*!
> + * \brief Initialize coalesced MMIO
> + *
> + * Check for coalesced MMIO capability and store in context
> + *
> + * \param kvm Pointer to the current kvm_context
> + */
> +int kvm_init_coalesced_mmio(kvm_context_t kvm);
> +
>  #ifdef KVM_CAP_PIT
>  
>  #if defined(__i386__) || defined(__x86_64__)
-- 
------------- Laurent.Vivier@bull.net ---------------
"The best way to predict the future is to invent it."
- Alan Kay


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] libkvm: export init for coalesced MMIO support
  2008-06-18  5:22 [PATCH] libkvm: export init for coalesced MMIO support Carlo Marcelo Arenas Belon
  2008-06-18  7:39 ` Laurent Vivier
@ 2008-06-18 14:27 ` Avi Kivity
  1 sibling, 0 replies; 3+ messages in thread
From: Avi Kivity @ 2008-06-18 14:27 UTC (permalink / raw)
  To: Carlo Marcelo Arenas Belon; +Cc: kvm

Carlo Marcelo Arenas Belon wrote:
> complement 2680f3df932a3119880a692609943587ecc8f409 to export the
> definition for kvm_init_coalesced_mmio as it is used by the per
> arch libkvm as shown by the following warning :
>
>   

Applied, thanks.


-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-06-18 14:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-18  5:22 [PATCH] libkvm: export init for coalesced MMIO support Carlo Marcelo Arenas Belon
2008-06-18  7:39 ` Laurent Vivier
2008-06-18 14:27 ` Avi Kivity

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox