public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Mark McLoughlin <markmc@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 0/3] kvm-guest-drivers-linux: Fix GSO/partial csum support on older kernels
Date: Fri, 20 Jun 2008 21:43:35 +0300	[thread overview]
Message-ID: <485BFA57.5030309@qumranet.com> (raw)
In-Reply-To: <1211888168-3814-1-git-send-email-markmc@redhat.com>

Mark McLoughlin wrote:
> Hi,
>         Here's a few patches to fix virtio_net GSO
> and partial csum support under older kernels.
>
>   

Applied all, thanks.  Sorry for the virtio-like latency in processing.

I don't much like the intense hackery involved in this.  The way I think 
it could be done is:

- hack virtio to use an API which is specific to kvm, but matches the 
current upstream API:

    s/net_func/virtio_compat_net_func/

  including data structures.

- define this API on top of the host kernel's real API.  For a recent 
enough kernel, that's a one-to-one mapping:

   virtio_compat_net_func() { return net_func(); }

  for older ones there's a more trickery involved.

  For kvm, this is a fairly successful strategy, but I imagine that for 
virtio-net this will be much, much, more difficult.

- write Documentation/stable_api_nonsense_nonsense.txt.


-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


      parent reply	other threads:[~2008-06-20 18:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-27 11:36 [PATCH 0/3] kvm-guest-drivers-linux: Fix GSO/partial csum support on older kernels Mark McLoughlin
2008-05-27 11:36 ` [PATCH 1/3] Fix partial csum rx handling Mark McLoughlin
2008-05-27 11:36   ` [PATCH 2/3] Fix partial csum tx handling Mark McLoughlin
2008-05-27 11:36     ` [PATCH 3/3] Fix GSO " Mark McLoughlin
2008-05-29  6:50   ` [PATCH 1/3] Fix partial csum rx handling Herbert Xu
2008-05-29  7:58     ` Mark McLoughlin
2008-05-29 10:01       ` Herbert Xu
2008-06-20 18:43 ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=485BFA57.5030309@qumranet.com \
    --to=avi@qumranet.com \
    --cc=kvm@vger.kernel.org \
    --cc=markmc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox