From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/3] kvm-guest-drivers-linux: Fix GSO/partial csum support on older kernels Date: Fri, 20 Jun 2008 21:43:35 +0300 Message-ID: <485BFA57.5030309@qumranet.com> References: <1211888168-3814-1-git-send-email-markmc@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from il.qumranet.com ([212.179.150.194]:23836 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751325AbYFTSng (ORCPT ); Fri, 20 Jun 2008 14:43:36 -0400 In-Reply-To: <1211888168-3814-1-git-send-email-markmc@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: > Hi, > Here's a few patches to fix virtio_net GSO > and partial csum support under older kernels. > > Applied all, thanks. Sorry for the virtio-like latency in processing. I don't much like the intense hackery involved in this. The way I think it could be done is: - hack virtio to use an API which is specific to kvm, but matches the current upstream API: s/net_func/virtio_compat_net_func/ including data structures. - define this API on top of the host kernel's real API. For a recent enough kernel, that's a one-to-one mapping: virtio_compat_net_func() { return net_func(); } for older ones there's a more trickery involved. For kvm, this is a fairly successful strategy, but I imagine that for virtio-net this will be much, much, more difficult. - write Documentation/stable_api_nonsense_nonsense.txt. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.