Re: [PATCH 1/4] KVM: Report hardware virtualization features

[Avi Kivity <avi@qumranet.com>]

Yang, Sheng wrote:
> From f02d2ccf01e8671d2da517f14a908d1df1cc42ad Mon Sep 17 00:00:00 2001
> From: Sheng Yang <sheng.yang@intel.com>
> Date: Thu, 19 Jun 2008 18:41:26 +0800
> Subject: [PATCH] KVM: Report hardware virtualization features
>
> The hardware virtualization technology evolves very fast. But currently it's
> hard to tell if your CPU support certain kind of HW technology without dig 
> into the source code.
>
> The patch introduced a virtual file called "kvm_hw_feature_report" under
> /sys/devices/system/kvm/kvm0 to show the mainly important current hardware
> virtualization feature, then it's pretty easy to tell if your CPU support
> some advanced virtualization technology now.
>
>   

Yes, this is definitely helpful.  However, I think that users will 
expect cpu flags under /proc/cpuinfo.

Perhaps we should add a new line 'virt flags' to /proc/cpuinfo?  I think 
all the features are reported using msrs, so it can be done from 
arch/x86/kernel/cpu/proc.c without involving kvm at all.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.