From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/4] KVM: Report hardware virtualization features Date: Sun, 22 Jun 2008 09:49:51 +0300 Message-ID: <485DF60F.4070907@qumranet.com> References: <200806191842.56275.sheng.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: "Yang, Sheng" Return-path: Received: from il.qumranet.com ([212.179.150.194]:32179 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751051AbYFVGtj (ORCPT ); Sun, 22 Jun 2008 02:49:39 -0400 In-Reply-To: <200806191842.56275.sheng.yang@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Yang, Sheng wrote: > From f02d2ccf01e8671d2da517f14a908d1df1cc42ad Mon Sep 17 00:00:00 2001 > From: Sheng Yang > Date: Thu, 19 Jun 2008 18:41:26 +0800 > Subject: [PATCH] KVM: Report hardware virtualization features > > The hardware virtualization technology evolves very fast. But currently it's > hard to tell if your CPU support certain kind of HW technology without dig > into the source code. > > The patch introduced a virtual file called "kvm_hw_feature_report" under > /sys/devices/system/kvm/kvm0 to show the mainly important current hardware > virtualization feature, then it's pretty easy to tell if your CPU support > some advanced virtualization technology now. > > Yes, this is definitely helpful. However, I think that users will expect cpu flags under /proc/cpuinfo. Perhaps we should add a new line 'virt flags' to /proc/cpuinfo? I think all the features are reported using msrs, so it can be done from arch/x86/kernel/cpu/proc.c without involving kvm at all. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.