From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/4] KVM: Report hardware virtualization features Date: Sun, 22 Jun 2008 15:21:37 +0300 Message-ID: <485E43D1.80009@qumranet.com> References: <200806191842.56275.sheng.yang@intel.com> <485DF60F.4070907@qumranet.com> <1214137094.31471.182.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Yang, Sheng" , kvm@vger.kernel.org To: dor.laor@qumranet.com Return-path: Received: from il.qumranet.com ([212.179.150.194]:32414 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbYFVMVi (ORCPT ); Sun, 22 Jun 2008 08:21:38 -0400 In-Reply-To: <1214137094.31471.182.camel@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: Dor Laor wrote: >> >> Yes, this is definitely helpful. However, I think that users will >> expect cpu flags under /proc/cpuinfo. >> >> Perhaps we should add a new line 'virt flags' to /proc/cpuinfo? I think >> all the features are reported using msrs, so it can be done from >> arch/x86/kernel/cpu/proc.c without involving kvm at all. >> >> > > while I agree with Avi, it would be nice thought to see them on older > kernels. At least sprinkle a printk message. > Oh we'll certainly hack something for the external modules. -- error compiling committee.c: too many arguments to function