From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/4] KVM: Report hardware virtualization features Date: Mon, 23 Jun 2008 05:40:33 +0300 Message-ID: <485F0D21.1000708@qumranet.com> References: <200806191842.56275.sheng.yang@intel.com> <1214137094.31471.182.camel@localhost.localdomain> <485E43D1.80009@qumranet.com> <200806230946.31172.sheng.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: dor.laor@qumranet.com, kvm@vger.kernel.org To: "Yang, Sheng" Return-path: Received: from il.qumranet.com ([212.179.150.194]:10996 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752564AbYFWCkU (ORCPT ); Sun, 22 Jun 2008 22:40:20 -0400 In-Reply-To: <200806230946.31172.sheng.yang@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Yang, Sheng wrote: > On Sunday 22 June 2008 20:21:37 Avi Kivity wrote: > >> Dor Laor wrote: >> >>>> Yes, this is definitely helpful. However, I think that users will >>>> expect cpu flags under /proc/cpuinfo. >>>> >>>> Perhaps we should add a new line 'virt flags' to /proc/cpuinfo? I think >>>> all the features are reported using msrs, so it can be done from >>>> arch/x86/kernel/cpu/proc.c without involving kvm at all. >>>> >>> while I agree with Avi, it would be nice thought to see them on older >>> kernels. At least sprinkle a printk message. >>> >> Oh we'll certainly hack something for the external modules. >> > > Yeah, add a virt flags is more directly, and I think it's not hard to be > accepted. I will do that. > > Perhaps just adding to the standard flags line is best, since tools already read it. > And as Dor said, I think we also need a relative elegant method for the > modules. So maybe we can keep these patches? Without that bash script. :) > > I'll just copy the code that finally makes it and put it in kernel/external-module-compat.c. Patches would stop applying soon. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.