From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] irq assignment Date: Wed, 25 Jun 2008 14:53:20 +0300 Message-ID: <486231B0.9080904@qumranet.com> References: <51CFAB8CB6883745AE7B93B3E084EBE201D2C53B@pdsmsx412.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, kvm-ia64@vger.kernel.org, qemu-devel To: "Xu, Anthony" Return-path: Received: from il.qumranet.com ([212.179.150.194]:52836 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700AbYFYLxW (ORCPT ); Wed, 25 Jun 2008 07:53:22 -0400 In-Reply-To: <51CFAB8CB6883745AE7B93B3E084EBE201D2C53B@pdsmsx412.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: (copying qemu-devel) Xu, Anthony wrote: > Subject: [PATCH] Irq assignment > > 1. use bimodal _PRT > 2. pci device can use irq > 15, reduce interrupt sharing > 3. test by running linux guest in kvm-ia64, kvm-i32(w/ wo/ -no-kvm) > > > + > +static int ioapic_irq_count[IOAPIC_NUM_PINS]; > + > void ioapic_set_irq(void *opaque, int vector, int level) > { > IOAPICState *s = opaque; > - > + if( vector >= 16 ){ > + if( level ) > + ioapic_irq_count[vector] += 1; > + else > + ioapic_irq_count[vector] -= 1; > + level = (ioapic_irq_count[vector] != 0); > + } > +#ifdef KVM_CAP_IRQCHIP > + if (kvm_enabled()) > + if (kvm_set_irq(vector, ioapic_irq_count[vector] == 0)) > + return; > +#endif > It's legal to call ioapic_set_irq(vector, 1) twice, which will screw up the level calculation. We need qemu_irq_or(), similar to qemu_irq_invert(): qemu_irq qemu_irq_or(qemu_irq irqs[], int nr); Also, this is not the place for doing the or. The ioapic does not know which interrupts are level connected and which are not. This belongs on the pci level (or the mainboard level). -- error compiling committee.c: too many arguments to function