From: Avi Kivity <avi@qumranet.com>
To: "Yang, Sheng" <sheng.yang@intel.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: VMX: Add ept_sync_context in flush_tlb
Date: Wed, 25 Jun 2008 15:02:17 +0300 [thread overview]
Message-ID: <486233C9.4060906@qumranet.com> (raw)
In-Reply-To: <200806181138.22990.sheng.yang@intel.com>
Yang, Sheng wrote:
> From 54dc26e44f1c0aa460bef409b799f36dae56a911 Mon Sep 17 00:00:00 2001
> From: Sheng Yang <sheng.yang@intel.com>
> Date: Wed, 18 Jun 2008 11:23:13 +0800
> Subject: [PATCH] KVM: VMX: Add ept_sync_context in flush_tlb
>
> Fix a potention issue caused by kvm_mmu_slot_remove_write_access().
> The old behavior don't sync EPT TLB with modified EPT entry, which
> result in inconsistent content of EPT TLB and EPT table.
>
>
> @@ -1407,6 +1408,8 @@ static void exit_lmode(struct kvm_vcpu *vcpu)
> static void vmx_flush_tlb(struct kvm_vcpu *vcpu)
> {
> vpid_sync_vcpu_all(to_vmx(vcpu));
> + if (vm_need_ept())
> + ept_sync_context(to_vmx(vcpu));
> }
>
So we're flushing both the vpid tlb and the ept context? What does an
ept context flush mean exactly? tlb entries for gpa->hpa?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-06-25 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 3:38 [PATCH] KVM: VMX: Add ept_sync_context in flush_tlb Yang, Sheng
2008-06-25 12:02 ` Avi Kivity [this message]
2008-06-26 0:47 ` Yang, Sheng
2008-06-29 10:09 ` Avi Kivity
2008-07-06 11:20 ` Yang, Sheng
2008-07-06 11:55 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486233C9.4060906@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=sheng.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox