From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: VMX: Add ept_sync_context in flush_tlb Date: Wed, 25 Jun 2008 15:02:17 +0300 Message-ID: <486233C9.4060906@qumranet.com> References: <200806181138.22990.sheng.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: "Yang, Sheng" Return-path: Received: from il.qumranet.com ([212.179.150.194]:54139 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756671AbYFYMCS (ORCPT ); Wed, 25 Jun 2008 08:02:18 -0400 In-Reply-To: <200806181138.22990.sheng.yang@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Yang, Sheng wrote: > From 54dc26e44f1c0aa460bef409b799f36dae56a911 Mon Sep 17 00:00:00 2001 > From: Sheng Yang > Date: Wed, 18 Jun 2008 11:23:13 +0800 > Subject: [PATCH] KVM: VMX: Add ept_sync_context in flush_tlb > > Fix a potention issue caused by kvm_mmu_slot_remove_write_access(). > The old behavior don't sync EPT TLB with modified EPT entry, which > result in inconsistent content of EPT TLB and EPT table. > > > @@ -1407,6 +1408,8 @@ static void exit_lmode(struct kvm_vcpu *vcpu) > static void vmx_flush_tlb(struct kvm_vcpu *vcpu) > { > vpid_sync_vcpu_all(to_vmx(vcpu)); > + if (vm_need_ept()) > + ept_sync_context(to_vmx(vcpu)); > } > So we're flushing both the vpid tlb and the ept context? What does an ept context flush mean exactly? tlb entries for gpa->hpa? -- error compiling committee.c: too many arguments to function