From: Avi Kivity <avi@qumranet.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Re: KVM: x86: move vapic page handling out of fast path
Date: Sun, 29 Jun 2008 14:53:44 +0300 [thread overview]
Message-ID: <486777C8.3030801@qumranet.com> (raw)
In-Reply-To: <20080623150425.GA30975@dmt.cnet>
Marcelo Tosatti wrote:
> On Mon, Jun 23, 2008 at 05:29:34AM +0300, Avi Kivity wrote:
>
>> The page can't be swapped out since its reference count is elevated
>> indefinitely.
>>
>
> AFAICT the page can be swapped out when the guest has exited to
> userspace and the only reference is the qemu userspace mapping.
>
>
That's true, but immaterial, as guests spend most of their time running
guest code or sleeping in the kernel.
We could drop the page while the guest is sleeping, but I'd like things
to work well even if the guest never idles.
> OK, can you please apply this at least:
>
> KVM: move slots_lock acquision down to vapic_exit
>
> There is no need to grab slots_lock if the vapic_page will not
> be touched.
>
>
Sure, applied.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-06-29 11:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 15:04 KVM: x86: move vapic page handling out of fast path Marcelo Tosatti
2008-06-29 11:53 ` Avi Kivity [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-06-19 17:43 Marcelo Tosatti
2008-06-22 5:00 ` Avi Kivity
2008-06-22 17:05 ` Marcelo Tosatti
2008-06-23 2:29 ` Avi Kivity
2008-06-23 14:47 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486777C8.3030801@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox