From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: KVM: x86: move vapic page handling out of fast path Date: Sun, 29 Jun 2008 14:53:44 +0300 Message-ID: <486777C8.3030801@qumranet.com> References: <20080623150425.GA30975@dmt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Marcelo Tosatti Return-path: Received: from il.qumranet.com ([212.179.150.194]:11666 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbYF2Lxp (ORCPT ); Sun, 29 Jun 2008 07:53:45 -0400 In-Reply-To: <20080623150425.GA30975@dmt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > On Mon, Jun 23, 2008 at 05:29:34AM +0300, Avi Kivity wrote: > >> The page can't be swapped out since its reference count is elevated >> indefinitely. >> > > AFAICT the page can be swapped out when the guest has exited to > userspace and the only reference is the qemu userspace mapping. > > That's true, but immaterial, as guests spend most of their time running guest code or sleeping in the kernel. We could drop the page while the guest is sleeping, but I'd like things to work well even if the guest never idles. > OK, can you please apply this at least: > > KVM: move slots_lock acquision down to vapic_exit > > There is no need to grab slots_lock if the vapic_page will not > be touched. > > Sure, applied. -- error compiling committee.c: too many arguments to function