From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0 of 4] [kvm-userspace][test] consolidate test libs to libcflat Date: Sun, 29 Jun 2008 16:24:19 +0300 Message-ID: <48678D03.3010109@qumranet.com> References: <48675175.9060709@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org To: Jerone Young Return-path: Received: from il.qumranet.com ([212.179.150.194]:33941 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755384AbYF2NYV (ORCPT ); Sun, 29 Jun 2008 09:24:21 -0400 In-Reply-To: <48675175.9060709@qumranet.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Jerone Young wrote: >> This set of patches are to consolidate test libraries into a single >> library archive. This lib archive is libcflat. This will allow common >> code to be shared among archs. >> >> > > Applied all, thanks. I squashed together 1-3 as Hollis suggested, and > with git's rename detection, one can see that you merged exit() puts() > etc into a single file. That usually doesn't work will with libraries > (if you define your own puts() but not your own exit(), you're in > trouble), but we can fix this if/when it starts to hurt. > > This fails compilation with: gcc -m64 -D__x86_64__ -I /tmp/BUILDER/kvm/rpmtop/BUILD/kernel/include -O1 -MMD -MF test/x86/.access.d -g -fomit-frame-pointer -Wa ll -fno-stack-protector -I ../libkvm -std=gnu99 -ffreestanding -I test/lib -I test/lib/x86 -c -o test/x86/access.o test/x86/a ccess.c test/x86/access.c:153: error: conflicting types for 'memset' /usr/include/string.h:59: error: previous declaration of 'memset' was here test/x86/access.c: In function 'ac_test_do_access': test/x86/access.c:511: warning: implicit declaration of function 'printf' test/x86/access.c: In function 'main': test/x86/access.c:578: warning: passing argument 1 of 'smp_init' from incompatible pointer type make[1]: *** [test/x86/access.o] Error 1 make[1]: Leaving directory `/tmp/BUILDER/kvm/rpmtop/BUILD/user' error: Bad exit status from /var/tmp/rpm-tmp.45450 (%build) So I'm unapplying these patches. -- error compiling committee.c: too many arguments to function