From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [GIT PULL] KVM fixes for 2.6.26-rc7 Date: Mon, 30 Jun 2008 17:35:02 +0300 Message-ID: <4868EF16.7000902@qumranet.com> References: <48616182.9030902@qumranet.com> <20080625191723.GA20531@dmt.cnet> <48633511.8000403@redhat.com> <200806261045.57192.bernd-schubert@gmx.de> <48639027.2040607@codemonkey.ws> <4863911F.5090807@qumranet.com> <20080626134357.GE21543@ralph.linux2go.dk> <48674EEF.3020500@qumranet.com> <20080630132144.GC8698@ralph.linux2go.dk> <4868E20B.5090106@qumranet.com> <20080630142150.GE8698@ralph.linux2go.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: kvm@vger.kernel.org Return-path: Received: from il.qumranet.com ([212.179.150.194]:13616 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752080AbYF3OfD (ORCPT ); Mon, 30 Jun 2008 10:35:03 -0400 In-Reply-To: <20080630142150.GE8698@ralph.linux2go.dk> Sender: kvm-owner@vger.kernel.org List-ID: Soren Hansen wrote: > On Mon, Jun 30, 2008 at 04:39:23PM +0300, Avi Kivity wrote: > >>>> Yeah. To be on the safe side you can have KVM_CHECK_EXTENSION >>>> return false for KVM_CAP_CLOCKSOURCE. >>>> >>> Oh! That's even better. Would that be sufficient? I mean, do all >>> guest versions check this before trying to use the paravirt clock? >>> >> You need to disable the host side (KVM_CAP_CLOCKSOURCE) and the guest >> side (CONFIG_KVM_GUEST). >> > > Well, we don't have KVM_GUEST in the Ubuntu 8.04 kernels anyway (them > being 2.6.24 based and all), so returning false for KVM_CAP_CLOCKSOURCE > should be sufficient, I presume? > > Yes. -- error compiling committee.c: too many arguments to function