Re: Freeze with KVM_CLOCK, undocumented dependency VIRTIO_BLK -> VIRTIO_PCI

[Avi Kivity <avi@qumranet.com>]

Mark McLoughlin wrote:
> I wonder would it be useful to default to building in (i.e. not as a
> module) virtio_pci if building with e.g. KVM_GUEST?
>
> There's two issues here:
>
>   1) It's easy to forget about virtio_pci - if we used KVM_GUEST as a 
>      general "this kernel may be run on KVM" config, then it would be a 
>      good hint that virtio_pci should be built
>
>   

Yeah.

>   2) Although we currently build virtio_pci as a module in Fedora, it 
>      leads to a pretty strange situation where e.g. mkinitrd and 
>      anaconda need to explicitly include the virtio_pci module; I 
>      don't think there's analogous situation where bus probing logic is 
>      in a module rather than built into the kernel
>
>   

Sounds like an mkinitrd bug.  When mkinitrd includes a module, it should 
also include all of its dependencies.

-- 
error compiling committee.c: too many arguments to function