From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Freeze with KVM_CLOCK, undocumented dependency VIRTIO_BLK -> VIRTIO_PCI Date: Thu, 03 Jul 2008 17:49:00 +0300 Message-ID: <486CE6DC.8020005@qumranet.com> References: <485DBBCD.5060600@codemonkey.ws> <1214993464.13909.7.camel@muff> <486CDC42.3070803@qumranet.com> <1215096268.7524.1.camel@muff> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , Bernhard Schmidt , kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from il.qumranet.com ([212.179.150.194]:18144 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752627AbYGCOtC (ORCPT ); Thu, 3 Jul 2008 10:49:02 -0400 In-Reply-To: <1215096268.7524.1.camel@muff> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: > >>> 2) Although we currently build virtio_pci as a module in Fedora, it >>> leads to a pretty strange situation where e.g. mkinitrd and >>> anaconda need to explicitly include the virtio_pci module; I >>> don't think there's analogous situation where bus probing logic is >>> in a module rather than built into the kernel >>> >>> >>> >> Sounds like an mkinitrd bug. When mkinitrd includes a module, it should >> also include all of its dependencies. >> > > It does ... but nothing requires virtio_pci ... > > Right, of course. Virtio requires *some* virtio bus, not necessarily virtio-pci. -- error compiling committee.c: too many arguments to function