From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Bug] Real mode guests never wake up after an HLT instruction Date: Sat, 05 Jul 2008 12:42:21 +0300 Message-ID: <486F41FD.109@qumranet.com> References: <52d4a3890806171502t2f6db2bdi3eef4aed354b2a81@mail.gmail.com> <485DFC00.5070008@qumranet.com> <52d4a3890806221134u4c5f0c52y4b25292583e1b877@mail.gmail.com> <5d6222a80807021318l3d7e472dh960a5a03848c35a7@mail.gmail.com> <52d4a3890807021508i3fe6a2cer5d246e3a41dfb075@mail.gmail.com> <52d4a3890807031516ja8df61q2ead8ab21eaaff65@mail.gmail.com> <52d4a3890807031530w2beaf2f3q716a28f597121565@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Glauber Costa , kvm@vger.kernel.org To: Mohammed Gamal Return-path: Received: from il.qumranet.com ([212.179.150.194]:48935 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751134AbYGEJmY (ORCPT ); Sat, 5 Jul 2008 05:42:24 -0400 In-Reply-To: <52d4a3890807031530w2beaf2f3q716a28f597121565@mail.gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: Mohammed Gamal wrote: > Sorry for the scrambled message. Here is the patch > > > +static inline void kvm_inject_db(struct kvm_vcpu *vcpu, u32 error_code) > +{ > + kvm_queue_exception_e(vcpu, DB_VECTOR, error_code); > +} IIRC debug exceptions don't push an error code. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.