Re: [PATCH] VT-d : changes to support KVM

[Avi Kivity <avi@qumranet.com>]

Ben-Ami Yassour wrote:
> From: Kay, Allen M <allen.m.kay@intel.com>
>
> This patch extends the VT-d driver to support KVM
>
> [Ben: fixed memory pinning]
>
> Signed-off-by: Kay, Allen M <allen.m.kay@intel.com>
> Signed-off-by: Weidong Han <weidong.han@intel.com>
> Signed-off-by: Ben-Ami Yassour <benami@il.ibm.com>
> ---
>  drivers/pci/dmar.c          |    4 +-
>  drivers/pci/intel-iommu.c   |  117 ++++++++++++++-
>  drivers/pci/intel-iommu.h   |  344 -------------------------------------------
>  drivers/pci/iova.c          |    2 +-
>  drivers/pci/iova.h          |   52 -------
>  include/linux/intel-iommu.h |  344 +++++++++++++++++++++++++++++++++++++++++++
>  include/linux/iova.h        |   52 +++++++
>  7 files changed, 512 insertions(+), 403 deletions(-)
>  delete mode 100644 drivers/pci/intel-iommu.h
>  delete mode 100644 drivers/pci/iova.h
>  create mode 100644 include/linux/intel-iommu.h
>  create mode 100644 include/linux/iova.h
>   

Please use the git diff '-M' flag (or set the 'diff.renames' config 
variable) so rename patches are reviewable.

>  
> +void kvm_intel_iommu_domain_exit(struct dmar_domain *domain)
> +{
> +	u64 end;
> +
> +	/* Domain 0 is reserved, so dont process it */
> +	if (!domain)
> +		return;
> +
> +	end = DOMAIN_MAX_ADDR(domain->gaw);
> +	end = end & (~PAGE_MASK_4K);
> +
> +	/* clear ptes */
> +	dma_pte_clear_range(domain, 0, end);
> +
> +	/* free page tables */
> +	dma_pte_free_pagetable(domain, 0, end);
> +
> +	iommu_free_domain(domain);
> +	free_domain_mem(domain);
> +}
> +EXPORT_SYMBOL_GPL(kvm_intel_iommu_domain_exit);
>   

I don't understand why the names are prefixed with 'kvm_'.  These are 
not kvm functions.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.