From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: KVM: mmu_shrink: kvm_mmu_zap_page requires slots_lock to be held
Date: Sat, 05 Jul 2008 15:01:16 +0300
Message-ID: <486F628C.10200@qumranet.com>
References: <20080703213302.GA17018@dmt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Izik Eidus <izike@qumranet.com>, kvm-devel <kvm@vger.kernel.org>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:52402 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751760AbYGEMBT (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 5 Jul 2008 08:01:19 -0400
In-Reply-To: <20080703213302.GA17018@dmt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Marcelo Tosatti wrote:
> kvm_mmu_zap_page() needs slots lock held (rmap_remove->gfn_to_memslot,
> for example).
>
> Since kvm_lock spinlock is held in mmu_shrink(), do a non-blocking
> down_read_trylock().
>   

Applied, thanks.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.