From: Avi Kivity <avi@qumranet.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: Alexander Graf <agraf@suse.de>, kvm@vger.kernel.org
Subject: Re: [PATCH] Ignore DEBUGCTL MSRs
Date: Sat, 05 Jul 2008 15:27:06 +0300 [thread overview]
Message-ID: <486F689A.6070703@qumranet.com> (raw)
In-Reply-To: <20080624134028.GG1303@amd.com>
Joerg Roedel wrote:
> Hi Alex,
>
> On Tue, Jun 24, 2008 at 07:04:45AM +0200, Alexander Graf wrote:
>
>> Netware writes and reads to the DEBUGCTL and LAST*IP MSRs without
>> further checks and is really confused to receive a #GP during that. To
>> make it happy we should just make them stubs, which is exactly what
>> SVM already does.
>>
>> To support VMX too, I put these in the generic code. Maybe the SVM
>> code could be cleaned up to use generic code too.
>>
>
> I would prefer if you put that into the VMX specific code. We can't move
> the SVM parts of it into generic code because Barcelona has hardware
> support to virtualize these registers. Therefore SVM don't need that
> in generic code.
>
The code path is svm_set_msr -> kvm_set_msr_common, so even if it is in
the common code path, you can still override it in svm specific code.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2008-07-05 12:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 5:04 [PATCH] Ignore DEBUGCTL MSRs Alexander Graf
2008-06-24 13:40 ` Joerg Roedel
2008-06-25 7:41 ` Alexander Graf
2008-07-05 12:27 ` Avi Kivity [this message]
2008-07-05 12:28 ` Avi Kivity
2008-07-09 12:48 ` Alexander Graf
2008-07-10 14:01 ` Avi Kivity
2008-07-16 9:26 ` Alexander Graf
2008-07-21 9:05 ` Avi Kivity
2008-07-22 6:00 ` Alexander Graf
2008-07-22 7:19 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486F689A.6070703@qumranet.com \
--to=avi@qumranet.com \
--cc=agraf@suse.de \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox