From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Ignore DEBUGCTL MSRs Date: Sat, 05 Jul 2008 15:27:06 +0300 Message-ID: <486F689A.6070703@qumranet.com> References: <4860806D.6000608@suse.de> <20080624134028.GG1303@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexander Graf , kvm@vger.kernel.org To: Joerg Roedel Return-path: Received: from il.qumranet.com ([212.179.150.194]:53127 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751784AbYGEM1I (ORCPT ); Sat, 5 Jul 2008 08:27:08 -0400 In-Reply-To: <20080624134028.GG1303@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: Joerg Roedel wrote: > Hi Alex, > > On Tue, Jun 24, 2008 at 07:04:45AM +0200, Alexander Graf wrote: > >> Netware writes and reads to the DEBUGCTL and LAST*IP MSRs without >> further checks and is really confused to receive a #GP during that. To >> make it happy we should just make them stubs, which is exactly what >> SVM already does. >> >> To support VMX too, I put these in the generic code. Maybe the SVM >> code could be cleaned up to use generic code too. >> > > I would prefer if you put that into the VMX specific code. We can't move > the SVM parts of it into generic code because Barcelona has hardware > support to virtualize these registers. Therefore SVM don't need that > in generic code. > The code path is svm_set_msr -> kvm_set_msr_common, so even if it is in the common code path, you can still override it in svm specific code. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.