From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Ignore DEBUGCTL MSRs Date: Sat, 05 Jul 2008 15:28:52 +0300 Message-ID: <486F6904.2040907@qumranet.com> References: <4860806D.6000608@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, joerg.roedel@amd.com To: Alexander Graf Return-path: Received: from il.qumranet.com ([212.179.150.194]:53206 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496AbYGEM2y (ORCPT ); Sat, 5 Jul 2008 08:28:54 -0400 In-Reply-To: <4860806D.6000608@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: > Netware writes and reads to the DEBUGCTL and LAST*IP MSRs without > further checks and is really confused to receive a #GP during that. To > make it happy we should just make them stubs, which is exactly what > SVM already does. > > To support VMX too, I put these in the generic code. Maybe the SVM > code could be cleaned up to use generic code too. > Please add a pr_unimpl() when bits that cause a real processor to do something are set. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.