Re: KVM: MMU: nuke shadowed pgtable pages and pte's on memslot destruction

Avi Kivity
2008-07-11T14:48:53Z

Marcelo Tosatti wrote:
> On Thu, Jul 10, 2008 at 01:58:24PM -0500, Hollis Blanchard wrote:
>
>>> This (and its friends) ought to be static inlines.
>>>
>>> On the other hand, don't the other arches have to flush their tlbs?
>>> Xiantao/Hollis? So maybe this function needs to be renamed
>>> kvm_flush_shadow() and implemented across the board.
>>>
>> Agreed, I think that's the right approach.
>>
>
> Ok, here it is, Hollis and Xiantao can you fill in the blanks?
>
> ----------
>
> Flush the shadow mmu before removing regions to avoid stale entries.
>
>

Applied, thanks.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.