From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: patch: qemu + hugetlbfs.. Date: Wed, 09 Jul 2008 12:11:50 -0500 Message-ID: <4874F156.2010708@codemonkey.ws> References: <4873E400.4000409@third-harmonic.com> <4873F395.6030209@codemonkey.ws> <4874051A.8000802@third-harmonic.com> <48740F86.3050306@codemonkey.ws> <20080709170301.GA11439@dmt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: john cooper , kvm@vger.kernel.org, john.cooper@redhat.com To: Marcelo Tosatti Return-path: Received: from rn-out-0910.google.com ([64.233.170.187]:62921 "EHLO rn-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475AbYGIRMQ (ORCPT ); Wed, 9 Jul 2008 13:12:16 -0400 Received: by rn-out-0910.google.com with SMTP id k40so870293rnd.17 for ; Wed, 09 Jul 2008 10:12:15 -0700 (PDT) In-Reply-To: <20080709170301.GA11439@dmt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > On Tue, Jul 08, 2008 at 08:08:22PM -0500, Anthony Liguori wrote: > >> john cooper wrote: >> >>> I like it even less. MAP_POPULATE does not fault in physical >>> hpages to the map. Again this was a qemu-side interim bandaid. >>> >> Really? That would seem like a bug in hugetlbfs to me. >> > > This is Linux's behaviour for all filesystems. There is no error > checking on MAP_POPULATE's attempt to prefault pages. > I thought that mmap() will fail with hugetlbfs if enough large pages can't be reserved? Regards, Anthony Liguori