From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] mask out clflush Date: Thu, 10 Jul 2008 08:30:14 -0500 Message-ID: <48760EE6.1070303@codemonkey.ws> References: <1215541784-26539-1-git-send-email-gcosta@redhat.com> <200807101843.57902.sheng.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Glauber Costa , glommer@gmail.com, avi@qumranet.com To: "Yang, Sheng" Return-path: Received: from py-out-1112.google.com ([64.233.166.181]:31686 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757971AbYGJNal (ORCPT ); Thu, 10 Jul 2008 09:30:41 -0400 Received: by py-out-1112.google.com with SMTP id p76so1826434pyb.10 for ; Thu, 10 Jul 2008 06:30:40 -0700 (PDT) In-Reply-To: <200807101843.57902.sheng.yang@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Yang, Sheng wrote: > On Wednesday 09 July 2008 02:29:44 Glauber Costa wrote: > >> clflush is a non-privileged instruction that flushes the cacheline >> given by its parameter, in terms of linear address. As it is >> non-privileged, it is quite tricky, because a guest doing clflush >> will actually be trying to flush a host kernel address. >> > > The linear address was convert to host physical address, then cache > line was flushed. Of course the host physical address was used by > guest at the time. I don't understand why we need to prevent guest > from flushing cache line related to itself... > The problem turned out to be that we aren't emulating clflush in x86_emulate. Regards, Anthony Liguori > -- > Thanks > Yang, Sheng > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >