Re: [Regression] kvm-userspace: VM freezes after booting FreeDOS

[Anthony Liguori <anthony@codemonkey.ws>]

Mohammed Gamal wrote:
> On Thu, Jul 10, 2008 at 7:31 PM, Anthony Liguori <anthony@codemonkey.ws> wrote:
>   
>> Mohammed Gamal wrote:
>>     
>>> After updating my kvm-userspace tree to the latest git tree. I am no
>>> more able to run FreeDOS. The VM freezes after choosing any of the
>>> boot options. I am running both latest kvm.git and kvm-userspace.git
>>>
>>>       
>> Can you bisect to the commit that broke it?
>>
>> Regards,
>>
>> Anthony Liguori
>>     
>
> I did, it seems that commit 04c3265c95c12e7c6e73cfd07357c05db6a1bda8
> caused it. Everything works fine after I reverted it.
>   

Thats:

commit 04c3265c95c12e7c6e73cfd07357c05db6a1bda8
Author: Jan Kiszka <jan.kiszka@web.de>
Date:   Fri May 16 09:21:47 2008 +0200

    kvm: qemu: consolidate kvm_eat_signal
   
    With the io thread signals are rare.  Remove looping over
    kvm_eat_signal and fold everything into kvm_main_loop_wait.
   
    Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
    Signed-off-by: Avi Kivity <avi@qumranet.com>


Hrm, that's disturbing.  Unfortunately, the patch is a bit more than 
just code motion.  It does change the number of times the lock is 
released and makes some minor changes to the code.  Nothing obvious that 
would cause the breakage without digging into it.

How did you create your freedos image?  I'd like to try and figure out 
what the problem is here since it may be causing other issues.

Regards,

Anthony Liguori

> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>