From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: KVM: MMU: nuke shadowed pgtable pages and pte's on memslot	destruction
Date: Fri, 11 Jul 2008 17:48:35 +0300
Message-ID: <487772C3.4070808@qumranet.com>
References: <20080704010618.GA25834@dmt.cnet> <486FAE8A.2050308@qumranet.com> <20080705192344.GA16596@dmt.cnet> <486FE48C.7030002@qumranet.com> <20080707173155.GB10372@dmt.cnet> <20080707195822.GA16787@dmt.cnet> <48761FCB.4080307@qumranet.com> <1215716304.16858.64.camel@localhost.localdomain> <20080710234931.GA5295@dmt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Hollis Blanchard <hollisb@us.ibm.com>,
	kvm-devel <kvm@vger.kernel.org>,
	"Zhang, Xiantao" <xiantao.zhang@intel.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:22978 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753856AbYGKOsx (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 11 Jul 2008 10:48:53 -0400
In-Reply-To: <20080710234931.GA5295@dmt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Marcelo Tosatti wrote:
> On Thu, Jul 10, 2008 at 01:58:24PM -0500, Hollis Blanchard wrote:
>   
>>> This (and its friends) ought to be static inlines.
>>>
>>> On the other hand, don't the other arches have to flush their tlbs?  
>>> Xiantao/Hollis?  So maybe this function needs to be renamed 
>>> kvm_flush_shadow() and implemented across the board.
>>>       
>> Agreed, I think that's the right approach.
>>     
>
> Ok, here it is, Hollis and Xiantao can you fill in the blanks?
>
> ----------
>
> Flush the shadow mmu before removing regions to avoid stale entries.
>
>   

Applied, thanks.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.