* [PATCH] VMX: Remove redundant check in handle_rmode_exception
@ 2008-07-12 13:02 Mohammed Gamal
2008-07-13 7:47 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Mohammed Gamal @ 2008-07-12 13:02 UTC (permalink / raw)
To: kvm; +Cc: avi, riel
Since checking for vcpu->arch.rmode.active is already done whenever we
call handle_rmode_exception(), checking it inside the function is redundant.
Signed-off-by: Mohammed Gamal <m.gamal005@gmail.com>
---
arch/x86/kvm/vmx.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 6145dbd..f6de4c6 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -2225,9 +2225,6 @@ static void kvm_guest_debug_pre(struct kvm_vcpu *vcpu)
static int handle_rmode_exception(struct kvm_vcpu *vcpu,
int vec, u32 err_code)
{
- if (!vcpu->arch.rmode.active)
- return 0;
-
/*
* Instruction with address size override prefix opcode 0x67
* Cause the #SS fault with 0 error code in VM86 mode.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] VMX: Remove redundant check in handle_rmode_exception
2008-07-12 13:02 [PATCH] VMX: Remove redundant check in handle_rmode_exception Mohammed Gamal
@ 2008-07-13 7:47 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2008-07-13 7:47 UTC (permalink / raw)
To: Mohammed Gamal; +Cc: kvm, riel
Mohammed Gamal wrote:
> Since checking for vcpu->arch.rmode.active is already done whenever we
> call handle_rmode_exception(), checking it inside the function is redundant.
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-13 7:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-12 13:02 [PATCH] VMX: Remove redundant check in handle_rmode_exception Mohammed Gamal
2008-07-13 7:47 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox