From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 01/04]Create x86 directory to hold x86-specific files. Date: Sun, 13 Jul 2008 11:53:37 +0300 Message-ID: <4879C291.9050602@qumranet.com> References: <42DFA526FC41B1429CE7279EF83C6BDC015F99FF@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-ia64@vger.kernel.org, kvm@vger.kernel.org To: "Zhang, Xiantao" Return-path: Received: from il.qumranet.com ([212.179.150.194]:20862 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751293AbYGMIxj (ORCPT ); Sun, 13 Jul 2008 04:53:39 -0400 In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC015F99FF@pdsmsx415.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Zhang, Xiantao wrote: > From 03ac444d1ab4446c587e8180ceaba60b9e75b28d Mon Sep 17 00:00:00 2001 > From: Xiantao Zhang > Date: Fri, 11 Jul 2008 10:13:08 +0800 > Subject: [PATCH] KVM: external module: Moving x86-speicif files to x86 > directory. > > Create x86 directory to hold x86-specific files. > Signed-off-by: Xiantao Zhang > --- > kernel/{ => x86}/anon_inodes.c | 0 > This isn't really x86 specific. It's just kernel version dependent. The problem is that it is built unconditionally, even if the kernel has anon_inodes support. Please send a patch that wraps the entire file in #ifdef so that we use the host kernel's anon_inodes if it is available. > kernel/{ => x86}/external-module-compat.c | 0 > kernel/{ => x86}/external-module-compat.h | 0 > Parts of this are generic, for example the mutex code. Please move only the x86 specifc parts (even if ia64 doesn't need everything in the generic code). -- error compiling committee.c: too many arguments to function