From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] VMX: Reinject real mode exception Date: Mon, 14 Jul 2008 14:30:28 +0300 Message-ID: <487B38D4.1070506@qumranet.com> References: <4879E9C8.2010208@web.de> <4879EFAE.3080805@qumranet.com> <4879F4C0.1090609@web.de> <487A1F26.7060700@qumranet.com> <487A1FE0.5040309@qumranet.com> <0B53E02A2965CE4F9ADB38B34501A3A10653F536@orsmsx505.amr.corp.intel.com> <487B24A1.3090309@qumranet.com> <487B2A63.5000802@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Nakajima, Jun" , kvm-devel , Mohammed Gamal , Anthony Liguori , Rik van Riel To: Jan Kiszka Return-path: Received: from il.qumranet.com ([212.179.150.194]:40451 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752054AbYGNLaa (ORCPT ); Mon, 14 Jul 2008 07:30:30 -0400 In-Reply-To: <487B2A63.5000802@web.de> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > As we execute real mode guests in VM86 mode, exception have to be > reinjected appropriately when the guest triggered them. For this purpose > the patch adopts the real-mode injection pattern used in vmx_inject_irq > to vmx_queue_exception, additionally taking care that the IP is set > correctly for #BP exceptions. Furthermore it extends > handle_rmode_exception to reinject all those exceptions that can be > raised in real mode. > > This fixes the execution of himem.exe from FreeDOS and also makes its > debug.com work properly. > > Note that guest debugging in real mode is broken now. This has to be > fixed by the scheduled debugging infrastructure rework (will be done > once base patches for QEMU have been accepted). > > Applied, thanks. -- error compiling committee.c: too many arguments to function