From: Avi Kivity <avi@qumranet.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: kvm <kvm@vger.kernel.org>, Carsten Otte <cotte@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: Re: [PATCH 1/2] kvm-s390: Fix guest kconfig for virtio
Date: Tue, 15 Jul 2008 13:57:00 +0300 [thread overview]
Message-ID: <487C827C.3070303@qumranet.com> (raw)
In-Reply-To: <200807151100.21769.borntraeger@de.ibm.com>
Christian Borntraeger wrote:
> Cornelia Huck noticed that a modular virtio without kvm guest support
> leads to a build error in the s390 virtio transport:
>
> CONFIG_VIRTIO=m leads to
> ERROR: "vmem_add_mapping" [drivers/s390/kvm/kvm_virtio.ko] undefined!
> ERROR: "max_pfn" [drivers/s390/kvm/kvm_virtio.ko] undefined!
> ERROR: "vmem_remove_mapping" [drivers/s390/kvm/kvm_virtio.ko] undefined!
>
> The virtio transport only works with kvm guest support and only as a
> builtin. Lets change the build process of drivers/s390/kvm/kvm_virtio.c
> to depend on kvm guest support, which is also a bool.
>
This leads to confusion if CONFIG_VIRTIO is unset but CONFIG_S390_GUEST
is set.
What about having CONFIG_S390_GUEST select CONFIG_VIRTIO instead?
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2008-07-15 10:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-15 8:56 [PATCH 0/2] kvm-s390: small fixes Christian Borntraeger
2008-07-15 9:00 ` [PATCH 1/2] kvm-s390: Fix guest kconfig for virtio Christian Borntraeger
2008-07-15 10:57 ` Avi Kivity [this message]
2008-07-15 11:52 ` Christian Borntraeger
2008-07-15 9:01 ` [PATCH 2/2] kvm-s390: change help text of guest Kconfig Christian Borntraeger
2008-07-15 11:00 ` Avi Kivity
2008-07-15 11:53 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487C827C.3070303@qumranet.com \
--to=avi@qumranet.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox