From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [patch 4/4] KVM-trace port to tracepoints Date: Thu, 17 Jul 2008 18:49:04 +0200 Message-ID: <487F7800.4010502@siemens.com> References: <20080717155724.897537670@polymtl.ca> <20080717160003.359557938@polymtl.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: akpm@linux-foundation.org, Ingo Molnar , linux-kernel@vger.kernel.org, Peter Zijlstra , Avi Kivity , kvm@vger.kernel.org, "Feng(Eric) Liu" To: Mathieu Desnoyers Return-path: Received: from lizzard.sbs.de ([194.138.37.39]:20504 "EHLO lizzard.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756165AbYGQQuF (ORCPT ); Thu, 17 Jul 2008 12:50:05 -0400 In-Reply-To: <20080717160003.359557938@polymtl.ca> Sender: kvm-owner@vger.kernel.org List-ID: Mathieu Desnoyers wrote: > Port/cleanup of KVM-trace to tracepoints. > > Tracepoints allow dormat instrumentation, like the kernel markers, but also > allows to describe the trace points in global headers so they can be easily > managed. They also do not use format strings. > > Anything that would involve an action (dereference a pointer, vmcs read, ...) > only required when tracing is placed in the probes created in kvm_trace.c > > This patch depends on the "Tracepoints" patch. > > Signed-off-by: Mathieu Desnoyers > CC: 'Peter Zijlstra' > CC: 'Feng(Eric) Liu' > CC: Avi Kivity > CC: kvm@vger.kernel.org > --- > arch/x86/kvm/vmx.c | 38 ++--- > arch/x86/kvm/x86.c | 43 ++---- > include/trace/kvm.h | 83 ++++++++++++ > virt/kvm/kvm_trace.c | 336 +++++++++++++++++++++++++++++++++++++++++++-------- > 4 files changed, 398 insertions(+), 102 deletions(-) Is it a specific property of KVM-trace that causes this LOC blow-up? Or is this a generic side-effect of tracepoints? [ Hmm, hope I didn't missed too much of the tracepoint discussion... ] Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux