Re: [patch 4/4] KVM-trace port to tracepoints

Jan Kiszka
2008-07-17T16:50:05Z

Mathieu Desnoyers wrote:
> Port/cleanup of KVM-trace to tracepoints.
>
> Tracepoints allow dormat instrumentation, like the kernel markers, but also
> allows to describe the trace points in global headers so they can be easily
> managed. They also do not use format strings.
>
> Anything that would involve an action (dereference a pointer, vmcs read, ...)
> only required when tracing is placed in the probes created in kvm_trace.c
>
> This patch depends on the "Tracepoints" patch.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
> CC: 'Peter Zijlstra' <peterz@infradead.org>
> CC: 'Feng(Eric) Liu' <eric.e.liu@intel.com>
> CC: Avi Kivity <avi@qumranet.com>
> CC: kvm@vger.kernel.org
> ---
> arch/x86/kvm/vmx.c | 38 ++---
> arch/x86/kvm/x86.c | 43 ++----
> include/trace/kvm.h | 83 ++++++++++++
> virt/kvm/kvm_trace.c | 336 +++++++++++++++++++++++++++++++++++++++++++--------
> 4 files changed, 398 insertions(+), 102 deletions(-)

Is it a specific property of KVM-trace that causes this LOC blow-up? Or
is this a generic side-effect of tracepoints?

[ Hmm, hope I didn't missed too much of the tracepoint discussion... ]

Jan

--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux