From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 5/5] Remove change to TARGET_PAGE_SIZE Date: Sat, 19 Jul 2008 10:50:33 +0300 Message-ID: <48819CC9.9070504@qumranet.com> References: <1216326515-20920-1-git-send-email-aliguori@us.ibm.com> <1216326515-20920-5-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from il.qumranet.com ([212.179.150.194]:56296 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417AbYGSHui (ORCPT ); Sat, 19 Jul 2008 03:50:38 -0400 In-Reply-To: <1216326515-20920-5-git-send-email-aliguori@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: > This is unnecessary sign-extension will do the Right Thing. Well, I think it is better to be explicit about it, but we do want to stay close to qemu, so I applied this. > Paul Brook also > objects strongly to it because it's unnecessary. > The smaller the patch, the stronger the objections. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.