From: Avi Kivity <avi@qumranet.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 3/5] Remove whitespace in VMDK code.
Date: Sun, 20 Jul 2008 11:47:54 +0300 [thread overview]
Message-ID: <4882FBBA.2080107@qumranet.com> (raw)
In-Reply-To: <4881FC2E.4010003@us.ibm.com>
Anthony Liguori wrote:
> Avi Kivity wrote:
>> Anthony Liguori wrote:
>>> Again, most likely a bad merge.
>>>
>>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>>>
>>> diff --git a/qemu/block-vmdk.c b/qemu/block-vmdk.c
>>> index 67dd2f1..843bf86 100644
>>> --- a/qemu/block-vmdk.c
>>> +++ b/qemu/block-vmdk.c
>>> @@ -93,6 +93,7 @@ typedef struct ActiveBDRVState{
>>>
>>> static ActiveBDRVState activeBDRV;
>>>
>>> +
>>> static int vmdk_probe(const uint8_t *buf, int buf_size, const char
>>> *filename)
>>> {
>>> uint32_t magic;
>>>
>>
>> Um. This adds whitespace. Reversed patch somehow?
>
> No, the whitespace is in QEMU SVN. It somehow got removed from the
> kvm-userspace tree.
>
Well, perhaps send the reversed patch to qemu-devel as a bugfix?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-07-20 8:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 20:28 [PATCH 1/5] Remove hypercall device Anthony Liguori
2008-07-17 20:28 ` [PATCH 2/5] Remove duplicate monitor definition Anthony Liguori
2008-07-17 20:28 ` [PATCH 3/5] Remove whitespace in VMDK code Anthony Liguori
2008-07-19 7:45 ` Avi Kivity
2008-07-19 14:37 ` Anthony Liguori
2008-07-20 8:47 ` Avi Kivity [this message]
2008-07-20 14:19 ` Anthony Liguori
2008-07-17 20:28 ` [PATCH 4/5] Remove unnecessary definition of hack_around_tap Anthony Liguori
2008-07-17 20:28 ` [PATCH 5/5] Remove change to TARGET_PAGE_SIZE Anthony Liguori
2008-07-19 7:50 ` Avi Kivity
2008-07-19 7:49 ` [PATCH 1/5] Remove hypercall device Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4882FBBA.2080107@qumranet.com \
--to=avi@qumranet.com \
--cc=aliguori@us.ibm.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox