From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 1/3] KVM: task switch: translate guest segment limit to virt-extension byte granular field Date: Mon, 21 Jul 2008 11:14:26 +0300 Message-ID: <48844562.6020200@qumranet.com> References: <20080719220806.152409866@localhost.localdomain> <20080719220932.835992589@localhost.localdomain> <488303BF.40702@qumranet.com> <20080720164352.GA5494@dmt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from il.qumranet.com ([212.179.150.194]:57283 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754026AbYGUIO1 (ORCPT ); Mon, 21 Jul 2008 04:14:27 -0400 In-Reply-To: <20080720164352.GA5494@dmt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > On Sun, Jul 20, 2008 at 12:22:07PM +0300, Avi Kivity wrote: > >> Marcelo Tosatti wrote: >> >>> If 'g' is one then limit is 4kb granular. >>> >>> Signed-off-by: Marcelo Tosatti >>> >>> Index: kvm-vmx-checks/arch/x86/kvm/x86.c >>> =================================================================== >>> --- kvm-vmx-checks.orig/arch/x86/kvm/x86.c >>> +++ kvm-vmx-checks/arch/x86/kvm/x86.c >>> @@ -3195,6 +3195,10 @@ static void seg_desct_to_kvm_desct(struc >>> kvm_desct->base |= seg_desc->base2 << 24; >>> kvm_desct->limit = seg_desc->limit0; >>> kvm_desct->limit |= seg_desc->limit << 16; >>> + if (seg_desc->g) { >>> + kvm_desct->limit <<= 12; >>> + kvm_desct->limit |= 0xfff; >>> + } >>> kvm_desct->selector = selector; >>> kvm_desct->type = seg_desc->type; >>> kvm_desct->present = seg_desc->p; >>> >>> >> This looks good, >> >> >>> @@ -3222,8 +3226,12 @@ static void get_segment_descritptor_dtab >>> if (kvm_seg.unusable) >>> dtable->limit = 0; >>> - else >>> - dtable->limit = kvm_seg.limit; >>> + else { >>> + if (kvm_seg.g) >>> + dtable->limit = kvm_seg.limit >> 12; >>> + else >>> + dtable->limit = kvm_seg.limit; >>> + } >>> dtable->base = kvm_seg.base; >>> >>> >> But this doesn't. As far as I can tell, users of >> get_segment_descritptor_dtable() expect a normalized limit (always in >> bytes). >> > > Ouch, yes. Here's it: > > > KVM: task switch: translate guest segment limit to virt-extension byte granular field > > If 'g' is one then limit is 4kb granular. > > I already merged this bit (I guess I forgot to ack); aren't you reading kvm-commits@? -- error compiling committee.c: too many arguments to function