From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Ignore DEBUGCTL MSRs Date: Mon, 21 Jul 2008 12:05:05 +0300 Message-ID: <48845141.7080701@qumranet.com> References: <4860806D.6000608@suse.de> <486F6904.2040907@qumranet.com> <4874B3B7.7060003@suse.de> <48761651.3030407@qumranet.com> <487DBECD.7000605@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, joerg.roedel@amd.com To: Alexander Graf Return-path: Received: from il.qumranet.com ([212.179.150.194]:17213 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753820AbYGUJFH (ORCPT ); Mon, 21 Jul 2008 05:05:07 -0400 In-Reply-To: <487DBECD.7000605@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Alexander Graf wrote: >> >>> + pr_unimpl(vcpu, "%s: MSR_IA32_DEBUGCTLMSR 0x%llx, nop\n", >>> + __func__, data); >>> >> >> We can avoid the printout if data == 0, since we support that case >> fully. > > I was thinking a lot about that. Even though we support data == 0, > usually the kernel log output is useful for people trying to find if > something is cause a problem. If they see that DEBUGCTL gets set, but > won't see it getting unset, they'd get confused IMHO. > So the current behavior is on purpose, but if you oppose to that idea, > please tell me. > Once it gets set, you can expect brokenness. It doesn't matter if it gets unset later. So IMO not printing on data == 0 is best: quiet on the cases we support, and loud on cases we don't. So yes, I'd prefer it changed. -- error compiling committee.c: too many arguments to function