From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: KVM: MMU: nuke shadowed pgtable pages and pte's on memslot destruction Date: Tue, 22 Jul 2008 08:18:41 +0300 Message-ID: <48856DB1.3000809@qumranet.com> References: <20080704010618.GA25834@dmt.cnet> <486FAE8A.2050308@qumranet.com> <20080705192344.GA16596@dmt.cnet> <486FE48C.7030002@qumranet.com> <20080707173155.GB10372@dmt.cnet> <20080707195822.GA16787@dmt.cnet> <48761FCB.4080307@qumranet.com> <1215716304.16858.64.camel@localhost.localdomain> <20080710234931.GA5295@dmt.cnet> <1216674207.22095.18.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm-devel , "Zhang, Xiantao" To: Hollis Blanchard Return-path: Received: from il.qumranet.com ([212.179.150.194]:23971 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751561AbYGVFS5 (ORCPT ); Tue, 22 Jul 2008 01:18:57 -0400 In-Reply-To: <1216674207.22095.18.camel@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: Hollis Blanchard wrote: > On Thu, 2008-07-10 at 20:49 -0300, Marcelo Tosatti wrote: > >> diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c >> index b850d24..2c438a7 100644 >> --- a/arch/powerpc/kvm/powerpc.c >> +++ b/arch/powerpc/kvm/powerpc.c >> @@ -170,6 +170,11 @@ int kvm_arch_set_memory_region(struct kvm *kvm, >> return 0; >> } >> >> +void kvm_arch_flush_shadow(struct kvm *kvm) >> +{ >> + return; >> +} >> + >> struct kvm_vcpu *kvm_arch_vcpu_create(struct kvm *kvm, unsigned int >> id) >> { >> struct kvm_vcpu *vcpu; >> > > By the way, what is the testcase for this, i.e. how do I remove a > memslot? > > 1. Memory hotunplug (perhaps not very relevant to embedded operating systems) 2. PCI memory resource remapping (aka framebuffers) -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.