From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [REGRESSION?] -no-kvm-irqchip broken with kvm.git Date: Tue, 22 Jul 2008 13:38:34 +0300 Message-ID: <4885B8AA.50105@qumranet.com> References: <4881A93E.5050402@web.de> <488396BE.9090909@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Jan Kiszka Return-path: Received: from il.qumranet.com ([212.179.150.194]:32044 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753202AbYGVKii (ORCPT ); Tue, 22 Jul 2008 06:38:38 -0400 In-Reply-To: <488396BE.9090909@web.de> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Jan Kiszka wrote: > >> Hi, >> >> I'm currently facing problems to get kvm working with -no-kvm-irqchip. >> It used to be fine up to kvm-71, but with latest git my Linux guest >> stalls during early boot: >> >> [ 22.631200] Freeing unused kernel memory: 324k freed >> [ 22.857098] SCSI subsystem initialized >> [ 22.892601] scsi0 : ata_piix >> [ 22.903604] scsi1 : ata_piix >> [ 22.904473] ata1: PATA max MWDMA2 cmd 0x00000000000101f0 ctl 0x00000000000103f6 bmdma 0x000000000001c000 irq 14 >> [ 22.917692] ata2: PATA max MWDMA2 cmd 0x0000000000010170 ctl 0x0000000000010376 bmdma 0x000000000001c008 irq 15 >> >> This seems to be a kernel-side issue, replacing the module set with the >> one that came with -71 fixes the issue. Maybe due to >> vmx_complete_interrupts refactoring? >> > > Looks like my suspect was right: Kicking vmx_complete_interrupts out of > vmx_vcpu_run makes -no-kvm-irqchip work again. > > Avi, could it be that 1c0f4f5011829dac96347b5f84ba37c2252e1e08 left > do_interrupt_requests outdated behind? Or is vmx_complete_interrupts > incorrectly queuing interrupts in the -no-kvm-irqchip case? > > I thought I tested out -no-kvm-irqchip, but apprently not well enough. I'll try to see what went wrong. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.