From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 4/4] KVM-trace port to tracepoints Date: Tue, 22 Jul 2008 21:46:25 +0300 Message-ID: <48862B01.7070907@qumranet.com> References: <20080717155724.897537670@polymtl.ca> <20080717160003.359557938@polymtl.ca> <487F7800.4010502@siemens.com> <20080717172853.GB29855@Krystal> <488604F8.1040008@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Mathieu Desnoyers , akpm@linux-foundation.org, Ingo Molnar , linux-kernel@vger.kernel.org, Peter Zijlstra , kvm@vger.kernel.org, "Feng(Eric) Liu" To: Jan Kiszka Return-path: Received: from il.qumranet.com ([212.179.150.194]:53046 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223AbYGVSq2 (ORCPT ); Tue, 22 Jul 2008 14:46:28 -0400 In-Reply-To: <488604F8.1040008@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > That's true - as long as you don't have to add/remove/modify > tracepoints. I had to do this job in the past (not for KVM). Having 1 > spot in 1 file (based on generic probes) would be handier in that case > than 5 spots in 3 files. But if the KVM tracepoints are considered > stable in their number and structure, that shouldn't be an issue here. > > Tracepoints aren't stable; they are artefacts of the implementation. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.