From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 4/4] KVM-trace port to tracepoints Date: Wed, 23 Jul 2008 13:08:41 +0300 Message-ID: <48870329.2080401@qumranet.com> References: <20080717155724.897537670@polymtl.ca> <20080717160003.359557938@polymtl.ca> <487F7800.4010502@siemens.com> <20080717172853.GB29855@Krystal> <488604F8.1040008@siemens.com> <48862B01.7070907@qumranet.com> <1216799346.7257.125.camel@twins> <4886E6FD.4090200@qumranet.com> <1216803303.7257.138.camel@twins> <20080723100314.GA2847@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Peter Zijlstra , Jan Kiszka , Mathieu Desnoyers , akpm@linux-foundation.org, Ingo Molnar , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, "Feng(Eric) Liu" To: Christoph Hellwig Return-path: Received: from il.qumranet.com ([212.179.150.194]:30229 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752566AbYGWKIm (ORCPT ); Wed, 23 Jul 2008 06:08:42 -0400 In-Reply-To: <20080723100314.GA2847@infradead.org> Sender: kvm-owner@vger.kernel.org List-ID: Christoph Hellwig wrote: > On Wed, Jul 23, 2008 at 10:55:03AM +0200, Peter Zijlstra wrote: > >> Andrew raised the whole point about trace_mark() generating an >> user-visible interface and thus it should be stable, and I agree with >> that. >> > > I'm not sure why this comes up again and again, but it's utter bullshit. > trace_mark does not generate any kind of user interface, just purely > a kernel internal interface. > trace_mark() is implement kvmtrace, which is propagated to userspace. So while trace_mark() itself is not a userspace interface, one of its users is. It's an unstable interface. But so is dmesg; that's the nature of tracing. -- error compiling committee.c: too many arguments to function