From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: device assignemnt: updated patches Date: Sat, 26 Jul 2008 12:05:49 +0300 Message-ID: <488AE8ED.2010301@qumranet.com> References: <1216728835-19721-1-git-send-email-benami@il.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: amit.shah@qumranet.com, kvm@vger.kernel.org, muli@il.ibm.com, weidong.han@intel.com, anthony@codemonkey.ws To: Ben-Ami Yassour Return-path: Received: from il.qumranet.com ([212.179.150.194]:50499 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751415AbYGZJFv (ORCPT ); Sat, 26 Jul 2008 05:05:51 -0400 In-Reply-To: <1216728835-19721-1-git-send-email-benami@il.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Ben-Ami Yassour wrote: > Following are the device assignment patches with the fixes of the > comments that were sent for the previous version. > > Here is the list of changes that were made with respect to the previous > version: > 1. Replace the interrupt ack hook patches with the notifiers list patch > by Avi. > 2. Remove code from ioapic - the ack notifier is called before the > checking the irr bit. > 3. Remove the interrupt ack work queue and handle it directly. > 4. Minimize the function for finding an assigned device. > 5. Remove the pt_lock, after making the changes above it is no longer > needed. > 6. Move declarations from kvm_para.h > 7. Add irq array to ioctl API. Note that this is only a change to the > API, currently only single irq is supported. > 8. Renaming: use "assigned device" and not "passthrough device" > 9. Fix device release error path > 10. Moving the assigned devices list pointer to the device struct itself > and remove the extra structure. > > Pending comment: shared guest interrputs are not tested. > > (and not implemented, either). Good progress; there are still many issues, but this is inevitable with such a large and complex patchset. How are we standing with merging the changes to the VT-d driver, which are a prerequisite? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.